Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code base refreshment + basic cypress setup #767

Merged
merged 8 commits into from
Jan 29, 2024
Merged

code base refreshment + basic cypress setup #767

merged 8 commits into from
Jan 29, 2024

Conversation

yandzee
Copy link
Collaborator

@yandzee yandzee commented Jan 23, 2024 •
edited
Loading

This PR:

  • Eliminates using of grpc-web and introduces short polling over basic http/1
  • Improves service map rendering, no mobx-based reactions for that (almost)
  • Initial code for cypress which will allow us to run normal E2E tests for the whole UI

@yandzee yandzee requested a review from a team as a code owner January 23, 2024 11:40
@yandzee yandzee requested review from geakstr and removed request for a team January 23, 2024 11:40
@yandzee yandzee self-assigned this Jan 24, 2024
@yandzee yandzee force-pushed the pr/renat/refreshment branch from fb0e31c to 682ab61 Compare January 24, 2024 15:17
@yandzee yandzee mentioned this pull request Jan 25, 2024
Closed
2 tasks
@geakstr
Copy link
Collaborator

geakstr commented Jan 29, 2024

Thanks @yandzee!

@geakstr geakstr merged commit 5a24882 into master Jan 29, 2024
8 checks passed
@geakstr geakstr deleted the pr/renat/refreshment branch January 29, 2024 14:51
@yandzee yandzee mentioned this pull request Jan 30, 2024
Closed
@devodev devodev mentioned this pull request Feb 17, 2024
Closed
2 tasks
@shashankram
Copy link

Hey @yandzee, what was the reason to replace the implementation based on grpc-web with http/1 polling?

@sagarmujumale sagarmujumale mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geakstr geakstr geakstr approved these changes

Assignees

@yandzee yandzee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yandzee @geakstr @shashankram